User Extender (prepareGroups functionality) #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzliedke
suggested changes
Jul 10, 2020
…ts, and deprecated PrepareUserGroups event
askvortsov1
force-pushed
the
as/user_groups_extender
branch
from
1bb2af6
to
6930299
Compare
franzliedke
reviewed
Jul 17, 2020
| @@ -12,6 +12,7 @@ | |||
| use Flarum\User\User; | |||
|
|
|||
| /** | |||
| * @deprecated beta 13, remove in beta 14. Use the User extender instead. | |||
There was a problem hiding this comment.
These numbers are not correct (anymore 🙈 ). Will fix this in master.
franzliedke
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Are we ok with the naming?
Confirmed
composer test).