Frontend Framework Rewrite (Mithril) #2126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oute code TODO: Fix "SyntaxError: '> li:not(.Dropdown-header)' is not a valid selector" when hovering search results in navbar
…ues with text and vnodes
…n posts, subtree retainer
…pp.modal.component when created
…aven't been ported yet
The property is 'params' instead of 'body' or 'data'
Now both extend src/common/components/Page.tsx Admin component is the exact same as common Forum component extends common & adds one line
Only the state has to be saved to app.cache.discussionList Cleans up the component class
…anager app.alerts.show() now can take plain object OR AlertState instance - will return AlertState.prototype.key app.alerts.dismiss() takes AlertState or state key (returned by show())
65 tasks
Merged
|
See #2255. Some code from this PR will be used in the new PR (work has been mostly done already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1821.
See #1950 for the library changes before Mithril.