Use absolute positioning for the Composer on Safari #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
reviewed
Mar 5, 2021
askvortsov1
approved these changes
Mar 6, 2021
There was a problem hiding this comment.
I don't have a Safari Mobile device to test.
I don't like the idea of having Safari-specific code in there because that means changing it will require having someone with Safari to check if it's still needed, but if there's no other solution so be it. Looks ok.
SychO9
force-pushed
the
sm/2652-iOS-composer-position
branch
from
f5ac9cb
to
c4f726b
Compare
|
I agree, I really don't like having browser specific code either, but there doesn't seem to be a solution for both safari & non-safari, seems like it's either this, or choosing one bug over the other. If we do go ahead with this solution, It'd be best not to use this util anywhere else unless really forced to such as this case. |
clarkwinkelmann
approved these changes
Mar 7, 2021
|
I can confirm that this fixes the issue after having a friend test on nightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652
Changes proposed in this pull request:
Use absolute positioning on Safari mobile, we can't use absolute positioning in all browsers because that causes other issues, however Safari mobile doesn't handle fixed positioning and inputs well either.
Reviewers should focus on:
I don't really like this tbh, there is no reliable way to tell what browser is used, the user agent string might change in the future, and feature inference (testing for specific features unique to the browser) is also not reliable as features might also be removed in the future.
I would have preferred trying to fix this on the JS side by maybe checking the composer position isn't off the viewport or perhaps trying somethings with a timeout before focusing on the text editor, but not being able to reproduce and test the issue doesn't help.
If anyone else has access to an iOS device and able to reproduce this wants to try and find a better fix please feel free.
Confirmed