Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing autocomplete attributes to input fields #3088

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

odnmalau
Copy link
Contributor

@odnmalau odnmalau commented Oct 1, 2021

Fixes #3019

Changes proposed in this pull request:
js/src/forum/components/LogInModal.js

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@davwheat
Copy link
Member

davwheat commented Oct 1, 2021

Thanks for the PR! We don't use React, and instead use mithril, meaning that we don't capitalise our attributes (props) like React does, so autoComplete should instead be autocomplete.

If you planned to do so, you might also want to add the appropriate attributes to the sign up and change password areas of Flarum. :)

@odnmalau
Copy link
Contributor Author

odnmalau commented Oct 1, 2021

OK, give me some time to do it.

@odnmalau
Copy link
Contributor Author

odnmalau commented Oct 2, 2021

Hi, I've updated it again, please check it

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@askvortsov1 askvortsov1 merged commit 0a7e885 into flarum:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing autocomplete attributes to input fields
4 participants