Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new translations for the user editting issue #3093

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Added new translations for the user editting issue #3093

merged 5 commits into from
Oct 13, 2021

Conversation

wotta
Copy link
Contributor

@wotta wotta commented Oct 6, 2021

Fixes #2899

Changes proposed in this pull request:
Added a new translation key and value that will tell the user they are not allowed to edit the user.

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

locale/core.yml Outdated Show resolved Hide resolved
@askvortsov1
Copy link
Sponsor Member

Thank you very much for the PR! Left a quick grammatical change request, but otherwise LGTM!

Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved tentatively.

Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
locale/core.yml Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, this looks great! We'll merge this soon after we release 1.1

@wotta
Copy link
Contributor Author

wotta commented Oct 6, 2021

Sorry I messed up. somehow my mind thought this was a json file and I added a comma. Removed it again😅

@askvortsov1 askvortsov1 merged commit 4146a4c into flarum:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing 'edite user' translation
3 participants