Better post loading support #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for https://github.com/flarum/core/issues/3043. Some posts are loaded dynamically, and won't be immediately available. In this case, we show a loading indicator instead of displaying content. In this PR: - We redraw post content if loading state has chnaged - We show a loading indicator while loading
askvortsov1
added a commit
to flarum/tags
that referenced
this pull request
Oct 11, 2021
Closes https://github.com/flarum/core/issues/3043 Depends on flarum/framework#3100 Before: https://i.imgur.com/TaYra03.png After: https://i.imgur.com/VB0GAVq.png **Questions for Reviewers** The `ShowTagController` change introduces ambiguity for fetching by ID vs slug, but I'm not sure that's avoidable, as the alternative is a `bySlug` query parameter, which would be a breaking change.
|
I thought we had skeleton posts for things like this don’t we? Oh this is just generic loading indicator support for child classes to use if desired, I think. Never mind then! |
davwheat
approved these changes
Oct 11, 2021
SychO9
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for https://github.com/flarum/core/issues/3043.
Some posts are loaded dynamically, and won't be immediately available. In this case, we show a loading indicator instead of displaying content. In this PR: