Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'typeof' in 'typeof this' from AdminPage#buildSettingComponent params #3142

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

dsevillamartin
Copy link
Member

Changes proposed in this pull request:

  • Jetbrains dies with typeof this, so I removed typeof as the functionality seems to remain with this: this
    • VSCode seems to parse it as this: this anyways

Reviewers should focus on:

Screenshot
Screenshots of IDEs before change:

PhpStorm
image

VSCode
image
image

Necessity

  • Has the problem that is being solved here been clearly explained?
    • It can't be; it's TypeScript
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

@davwheat
Copy link
Member

It can't be; it's TypeScript

Couldn't have put it better myself 🤣

@davwheat davwheat added this to the 1.2 milestone Oct 29, 2021
@davwheat davwheat added this to In progress in Typescript rewrite via automation Oct 29, 2021
@davwheat davwheat merged commit 7058895 into master Oct 29, 2021
@davwheat davwheat deleted the ds/adminpage-build-setting-component-type-error branch October 29, 2021 22:37
Typescript rewrite automation moved this from In progress to Done Oct 29, 2021
@davwheat
Copy link
Member

hacktoberfest++;

:))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants