Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Component.component argument typings #3148

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Nov 3, 2021

Changes proposed in this pull request:

Fix typings for the .component() helper method -- children was typed as undefined | null due to a lack of explicit typings on the method.

Reviewers should focus on:

None.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.2 milestone Nov 3, 2021
@davwheat davwheat self-assigned this Nov 3, 2021
@davwheat davwheat added this to In progress in Typescript rewrite via automation Nov 3, 2021
@davwheat davwheat merged commit 8c47b19 into master Nov 4, 2021
@davwheat davwheat deleted the dw/fix-component-method-typings branch November 4, 2021 21:38
Typescript rewrite automation moved this from In progress to Done Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants