Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Post--by-actor not showing when comparing user instances #3170

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 19, 2021

Fixes #2750

Changes proposed in this pull request:
Compare IDs since the discussion author relation can be unavailable.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat
Copy link
Member

Thanks for tracking this down! I had noticed it a few times, but then when I'd go back to check, it'd suddenly be fixed again. :)

@SychO9 SychO9 merged commit d82ae27 into master Nov 19, 2021
@SychO9 SychO9 deleted the sm/2750-compare-user-ids branch November 19, 2021 17:41
@SychO9 SychO9 mentioned this pull request Mar 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author badge css not loaded unless triggered from the discussion list
3 participants