Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing files for our translator libraries #3175

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Add typing files for our translator libraries #3175

merged 2 commits into from
Nov 26, 2021

Conversation

askvortsov1
Copy link
Sponsor Member

Title says it all.

davwheat
davwheat requested changes Nov 22, 2021
View reviewed changes
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not go in our global types folder?

@askvortsov1
Copy link
Sponsor Member Author

Should this not go in our global types folder?

No, as we don't export these libraries to be globally available

@askvortsov1 askvortsov1 merged commit 71cb8c3 into master Nov 26, 2021
@askvortsov1 askvortsov1 deleted the as/translator-lib-typings branch November 26, 2021 22:26
@SychO9 SychO9 added this to the 1.2 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@SychO9 SychO9 SychO9 approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@askvortsov1 @davwheat @SychO9