Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use app baseUrl instead of location.origin #3216

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

PostMeta contains a permalink to a post, however this link is generated with window.location.origin instead of app.forum.attribute('baseUrl'), meaning that if Flarum is installed as a subdirectory, these links would be invalid as they would miss the subdirectory.

Reviewers should focus on:

N/A

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Dec 20, 2021
@davwheat davwheat merged commit a1cc456 into master Dec 20, 2021
@davwheat davwheat deleted the dw/fix-postmeta-permlink branch December 20, 2021 16:25
@askvortsov1 askvortsov1 added this to the 1.2 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants