Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: include request info in first accesstoken touch #3233

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Dec 28, 2021

Fixes: #3234

Changes proposed in this pull request:

Prevents two separate DB updates as a result of sequential token ->touch()es.

image

If a user selects the Remember option, the last activity timestamp is updated in that middleware, then the IP and user agent is updated in the session auth middleware.

These two separate requests can be merged by actually providing the request info to the touch method in the remember middleware.

Reviewers should focus on:

N/A

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@davwheat davwheat merged commit 8096207 into master Dec 28, 2021
@davwheat davwheat deleted the dw/reduce-accesstoken-requests branch December 28, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessToken DB updates duplicated when 'Remember me' is selected
3 participants