Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unwarranted a11y warnings on custom Button subclasses #3238

Merged
merged 4 commits into from
Dec 29, 2021

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

UploadImageButton has its own content in the view method, so we don't need the empty children a11y warning.

Reviewers should focus on:

N/A

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.2 milestone Dec 28, 2021
@davwheat davwheat self-assigned this Dec 28, 2021
@davwheat davwheat changed the title fix: prevent unwarranted a11y warnings on UploadImageButton fix: prevent unwarranted a11y warnings on custom Button subclasses Dec 29, 2021
@davwheat davwheat merged commit 2541cde into master Dec 29, 2021
@davwheat davwheat deleted the dw/a11y-ulb branch December 29, 2021 09:37
@davwheat davwheat mentioned this pull request Mar 28, 2022
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants