Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better composer minimize behaviour #191

Closed
tobyzerner opened this issue Jul 28, 2015 · 1 comment
Closed

Better composer minimize behaviour #191

tobyzerner opened this issue Jul 28, 2015 · 1 comment

Comments

@tobyzerner
Copy link
Contributor

From http://discuss.flarum.org/d/396/general-ux/1:

When a reply box is minimized, make mouse hover maximize it, and mouse out minimize it, until a maximize button is clicked again to make it stick up. Good when you're reading another topic with it minimized, but want to check your reply quickly.

To keep things simple, I think we should not require clicking a maximise button, but instead only keep the composer maximised if a text field in the composer has focus.

What needs to be done:

  • Alter the Composer component to implement this behaviour. It might be a little complicated, but basically I imagine the steps would be:
    • Change the view's click handler to a mouseover handler that shows the composer if it is minimized
    • Add a mouseout handler that minimises the composer if the text field does not have focus (I think there is already a flag for this)
    • Also add a handler so that when focus is lost from the text field, the composer minimises
@tobyzerner
Copy link
Contributor Author

Changed my mind about this. It's fine (and intuitive) the way it is 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant