Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mentions] Allow mentioning groups #2175

Closed
askvortsov1 opened this issue May 19, 2020 · 8 comments
Closed

[Mentions] Allow mentioning groups #2175

askvortsov1 opened this issue May 19, 2020 · 8 comments
Labels
stale Issues that have had over 90 days of inactivity

Comments

@askvortsov1
Copy link
Sponsor Member

Feature Request

If groups are used to indicate teams, it would be useful to be able to mention a group of users and have all of them be notified.

@luceos
Copy link
Member

luceos commented May 19, 2020

A technical issue with this is that one would have to prevent users to use the same slug or maybe prefix the slug with group-?

@askvortsov1
Copy link
Sponsor Member Author

I've been in favor of requiring unique slugs for groups (in addition to the name) for a while now, provisioning based on ID is an absolute headache

@clarkwinkelmann
Copy link
Member

This raises the question of which part of our codebase should be responsible for each of those features:

  • Which one registers group slugs
  • Which one verifies the uniqueness of slugs across usernames and groups

I expect some complicated settings to be needed for such a feature due to the potential for abuse.

Maybe it would make more sense to delegate this to some kind of "Teams" community extension which would handle everything without over-complicating our core software and core extensions.

What would be the use cases of a group mention extension be and why would it belong in the core ecosystem? I don't think I have seen many requests for such a feature.

@askvortsov1
Copy link
Sponsor Member Author

If we go the route in https://github.com/flarum/core/issues/1734#issuecomment-644391424, we don't need slugs for groups, and can just store the group ID, preixed by "G". That would alleviate all these issues

@stale
Copy link

stale bot commented Oct 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale Issues that have had over 90 days of inactivity label Oct 10, 2020
@tankerkiller125
Copy link
Contributor

Still relevant, possibly something to work out during the UTF-8 work for beta 15

@stale stale bot removed the stale Issues that have had over 90 days of inactivity label Oct 11, 2020
@stale
Copy link

stale bot commented Jan 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale Issues that have had over 90 days of inactivity label Jan 10, 2021
@stale
Copy link

stale bot commented Feb 9, 2021

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

@stale stale bot closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that have had over 90 days of inactivity
Projects
None yet
Development

No branches or pull requests

4 participants