Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling/Disabling extensions should clear the cache #3758

Open
SychO9 opened this issue Mar 13, 2023 · 2 comments
Open

Enabling/Disabling extensions should clear the cache #3758

SychO9 opened this issue Mar 13, 2023 · 2 comments
Labels

Comments

@SychO9
Copy link
Member

SychO9 commented Mar 13, 2023

Current Behavior

If you toggle an extension, the cache is not cleared. Cache clearing is necessary for situations where an extension being toggled requires for example, the formatter cache to be rebuilt so that it correctly renders content. This example situation occurs when an extension adds custom fomatter tags that optionally rely on another extension.

Such as the mentions extension adding support for tag mentions.

Steps to Reproduce

Toggle an extension that requires cache clearing.

Expected Behavior

Cache should be cleared.

Screenshots

No response

Environment

  • Flarum version: x.y.z
  • Website URL: http://example.com
  • Webserver: [e.g. apache, nginx]
  • Hosting environment: [e.g. shared, vps]
  • PHP version: x.y.z
  • Browser: [e.g. chrome 67, safari 11]

Output of php flarum info

Output of "php flarum info", run this in terminal in your Flarum directory.

Possible Solution

No response

Additional Context

No response

@davwheat
Copy link
Member

Anecdotally, enabling extensions also doesn't publish frontend assets bundled with the extension.

Not sure if this is an issue or my local environment, though.

@SychO9
Copy link
Member Author

SychO9 commented Mar 13, 2023

enabling extensions also doesn't publish frontend assets bundled with the extension.

Yea I don't think it does, we should centralise the listener for enabling/disabling extensions (logic is duplicated throughout the codebase) and then we should improve it to include what is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants