Add "you need to confirm your email" informational message with "resend" functionality

[tobyzerner]

No description provided.

[Averell7]

Perhaps it is useless, but since no description was given to this "bug", I explain what happens :

• flarum 0.1.0-beta-4
• New user signs up, but does not confirm.
• He tries to Log In
• The proper message appears : _You need to confirm your email before you can log in. We've sent a confirmation email ... _
• Strangely enough, there is a DEBUG indication with :

401 Unauthorized
POST http://<forum url>/login
{
  "emailConfirmationRequired": "<email address>"
}

The indicated forum url and email address are correct.

• Nevertheless, an email is sent with an incorrect content :

Hey <user>!
Someone (hopefully you!) has changed their email address on <forum name> to this one.
If this was you, simply click the following link and your email will be confirmed:
http://xxxxxxxxxxxxxx
If this was not you, please ignore this email.

The link is correct and works, but the message is disturbing for the new user who does not understand.

If this issue was really about this situation, it is more a bug than a feature.

I am unsure, but maybe the error is in : flarum\core\src\Api\Controller\TokenController.php
because you find there the following code :

if (! $user->is_activated) {
            $this->events->fire(new UserEmailChangeWasRequested($user, $user->email));

            return new JsonResponse(['emailConfirmationRequired' => $user->email], 401);
        }

As far as I understand, this code does not make much sense. Probably an unfinished job.