Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top of Emojis in Safari is slightly cut #264

Open
ibrahimk157 opened this issue Nov 30, 2018 · 8 comments
Open

Top of Emojis in Safari is slightly cut #264

ibrahimk157 opened this issue Nov 30, 2018 · 8 comments
Assignees
Labels

Comments

@ibrahimk157
Copy link

When viewing some emojis in safari, they appear to be cut in the top.

Here’s a screenshot:
https://i.imgur.com/sw8AOf5.jpg

@jordanjay29
Copy link

jordanjay29 commented Nov 30, 2018

@garygomes
Copy link

Just to note I am getting the very same issue using an iPhone XS Max (iOS 12.1) on Safari.

It seems to be only present on some discussions. One discussion has the top of the emoji cut off, but on another discussion the emoji displays correctly. The only difference being the emoji is on the first line on one discussion as opposed to being on the second line (and more) on the other discussion if that makes sense.

@dsevillamartin
Copy link
Member

Seems to be caused by the vertical align being negative.

image

image


Looks like the problem is solved by making the top margin .1em as well

image

Same as

margin: .1em;
margin-bottom: 0;

This solution does make a small difference in line height though.

Safari > macOS

Untitled

Safari > iOS (iPhone Xr)

Untitled

@luceos
Copy link
Member

luceos commented Nov 15, 2019

Needs confirmation on osx/safari, check PR.

@tankerkiller125
Copy link

@luceos Checked with OSX/Safari (VM) and confirmed the Emoji are now displayed properly both with and without the PR in OSX 10.15.2, however because it's a VM with limited screen resolution I wonder if this is possibly more of a bug based on resolution?

@luceos
Copy link
Member

luceos commented Dec 11, 2019

I had to send in my macbook for repairs, so until we can confirm on a native osx machine, let's keep it open. Thanks for looking at it @tankerkiller125 ;)

@askvortsov1
Copy link
Sponsor Member

@luceos any chance you could check if this is still relevant? As a proud non-mac user I'm kinda useless here :D

@luceos
Copy link
Member

luceos commented Aug 14, 2020

Cannot reproduce on desktop safari, it was confirmed on mobile which I cannot reconfirm as I don't have an iPhone.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants