registerValidator with fast JSON decoding only #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
been running in Goerli + Sepolia for a while |
metachris
force-pushed
the
regval2
branch
2 times, most recently
from
82f47ae
to
012a2c9
Compare
Codecov Report
π£ This organization is not using Codecovβs GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 19.59% 19.96% +0.36%
==========================================
Files 20 20
Lines 3971 4023 +52
==========================================
+ Hits 778 803 +25
- Misses 3099 3119 +20
- Partials 94 101 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
deployed to prod earlier today |
metachris
force-pushed
the
regval2
branch
5 times, most recently
from
51bf227
to
250f52d
Compare
|
Did a bit more cleanup, and made sure we don't run into a possible int64 overflow with using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Processing validator registrations with buger/jsonparser only.
β I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md