Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mev-boost to call getPayload on all relays (instead of only those which sent the bid)? #530

Closed
metachris opened this issue Jun 14, 2023 · 3 comments · Fixed by #531

Comments

@metachris
Copy link
Collaborator

Could be useful for additional data availability -- in case relay which sent the bid can't retrieve the payload, other relays might still possess them, even if they haven't sent the bid.

Only downside I can see is that it will cause light additional load and logging on all relays, if getPayload gets called on all of them for most slots. Doesn't seem big of a downside really.

@ralexstokes
Copy link
Collaborator

the reason we need this just kind of speaks to the brittleness of this layer of the stack, and ideally we would just work to harden this layer of the stack

at the same time, I think there will also be some risk that this proposal would nullify and I agree the costs for the relays is fairly minimal

we can also make changes to the relay code base to minimize the logging etc

@benhenryhunter
Copy link

benhenryhunter commented Jun 15, 2023

I feel that this is pretty important for standard redundancy along with the increase in recent instability of beacon clients.

There is a bit of uncertainty that a beacon client could be running properly for a relay at any given time.

edited to add that I don't think we should have two sets of relays in mev-boost though one for headers and one for payloads... just seems unstable.

@metachris
Copy link
Collaborator Author

Discussed in detail in mev-boost community call #4, agreed to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants