Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the Friends feature. #15

Closed
Zageron opened this issue Apr 18, 2020 · 3 comments
Closed

Complete the Friends feature. #15

Zageron opened this issue Apr 18, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Zageron
Copy link
Member

Zageron commented Apr 18, 2020

Currently the Friends and FriendsMenu classes remain unused.

@Zageron Zageron added enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2020
@maxproske maxproske removed the good first issue Good for newcomers label Apr 28, 2020
@G-flat
Copy link
Member

G-flat commented Jul 22, 2020

Progress update:

I've got the Friends menu to work again. Currently, you could see the statuses of all of your friends in that menu. These statuses include 'Online', 'Offline', 'Playing FFR' and 'Playing FFR - [Song name]'.

When clicking a friend entry, it's height increases, but that's it. Is it supposed to show something else on click?

I've shown the menu to a few people in the #dev-chitchat Discord channel, and they suggested adding colours to the statuses (e.g. green for 'Online', red for 'Offline') and also tabs for looking for friends with a specific status only.

On an unrelated note, @Psycast said you've commented out the Friends menu, but then suggested adding it back in for some reason. He considers this menu to be not very useful. Should I continue working on this feature request, or should I close it?

@G-flat G-flat self-assigned this Jul 22, 2020
@G-flat G-flat added the question Further information is requested label Aug 1, 2020
@Zageron
Copy link
Member Author

Zageron commented Aug 6, 2020

If you've done work on it I'd argue to finishing it and then we can hide it behind a toggle at worst. More features is best, that way we could at least test them out with people and see if they like it. My suggestion for finishing the feature was essentially we should either finish it or get rid of it, though I didn't mention the second part.

@G-flat G-flat mentioned this issue Aug 8, 2020
@G-flat G-flat removed the question Further information is requested label Aug 8, 2020
@Zageron
Copy link
Member Author

Zageron commented Jun 13, 2021

Closing this, feel free to reopen.

@Zageron Zageron closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants