Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite Songs #24

Closed
Sploder12 opened this issue Apr 30, 2020 · 5 comments · Fixed by #222
Closed

Favorite Songs #24

Sploder12 opened this issue Apr 30, 2020 · 5 comments · Fixed by #222
Assignees
Labels
enhancement New feature or request

Comments

@Sploder12
Copy link
Member

When selecting a song there is a button that allows to favorite a song. This could be used while filtering songs or as a new tab in the Genre List.

@Sploder12 Sploder12 added the enhancement New feature or request label Apr 30, 2020
@G-flat
Copy link
Member

G-flat commented Jun 27, 2020

In the song filter menu, you could use the 'Personal Rating' filter to display songs depending on the ratings you've given to them. These ratings range from 0 (no rating) to 5 (max), with increments of 0.5 in between.

This leaves adding a new 'My favourites' tab in the genre list. In your opinion, what is the minimum rating required for a song to be considered a favourite?

@G-flat G-flat added the question Further information is requested label Jun 27, 2020
@Zageron
Copy link
Member

Zageron commented Jun 27, 2020

Probably a heart symbol. But filtering by 5 star might be more realistic.

@Xyr00
Copy link
Contributor

Xyr00 commented Jun 27, 2020

I like Zag's idea. As I mentioned in Discord there are a lot of instances where I think a file is great and fits the song well, and might even be a 5-star quality file to me. But say, for example, I don't like the music itself. Or the length is too long. Or I only "favorite" chiptune files. This would allow me to run favorite & ratings separately. Something like the below, with a hover tool-tip scenario saying "Add to Favorites" (& have it be an outline if not favorited):

image

image

@G-flat
Copy link
Member

G-flat commented Jun 29, 2020

I have asked the OP (@Sploder12) in Discord about their thoughts on implementing this feature request, and they have stated that @Xyr00's idea is what they were looking for, with the fire icon being a heart instead.

@G-flat G-flat removed the question Further information is requested label Jun 29, 2020
@Zageron
Copy link
Member

Zageron commented Jun 29, 2020

Awesome! So whoever wants to take this make sure you assign yourself! :)

@Psycast Psycast self-assigned this Aug 29, 2020
Psycast added a commit that referenced this issue Sep 18, 2020
### Favorite Songs:
This adds a Heart found within the Song Options / Notes Popup to mark a song as a favorite.
This has been included in the song filter system as well.

Resolves #24 

### Song Selection:
- Changes the list to denote favorite songs  by changing the difficulty to pink and adding s small triangle to the top left of the box.
- Changes the song info panel to show personal song rating instead of the site global rating. This is also smaller and shouldn't overlay with any song title now.

This also now allows Alt Engine songs to have a song rating which are stored locally.

### Level Ranks:
Add 3 new fields to level ranks that have been requested of the years. The primary uses of the new fields is to accurately mark songs that have previously accomplished a FC, but the current best score doesn't reflect that.
On the song selection screen, if the FC count is above 0, it will display `FC*` as a low priority flag.
The new flag is included in the filter system as well.

Adds:
- Play Count
- AAA Count
- FC Count

Resolves #2

### Other:
- Simplify Engine Brand String constants.
- Move set icon color into UIIcon.
- Remove PopupSongRating.as, PopupSongNotes effectively replaces it in function.
- Always show the Star on song results, which now leads to Song Notes instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants