Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loading when accessing in-game song leaderboards out-of-bounds #57

Closed
G-flat opened this issue Jun 1, 2020 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@G-flat
Copy link
Member

G-flat commented Jun 1, 2020

Describe the bug
When accessing the leaderboard from the results screen of a song in-game and moving to a page that is beyond the bottom of the leaderboard, it loads infinitely.

Screenshots
At the time of submitting this issue, there were 362 players for endleSSStation.
screen1

Accessing the leaderboard out-of-bounds:
screen2

Reproduction Steps
Follow these steps to reproduce bug:

  1. Go to the leaderboard of any song in-game.
  2. Move to a page that is beyond the bottom of the leaderboard.
  3. A loading icon should show up and not disappear no matter how long a user stays on that page.

Reproduction Rate
This bug occurs 100% of the time.

Expected behaviour
The leaderboard could either display an empty page when accessed out-of-bounds or forbid users from going beyond the bottom of the leaderboard (similar to how users cannot go to page 0, page -1 etc.).

Desktop (please complete the following information):

  • Platform: Air
  • Version: 1.1.1 (happens in all versions including 1.2.1)
@G-flat G-flat added the bug Something isn't working label Jun 1, 2020
Psycast added a commit that referenced this issue Jun 10, 2020
Zageron added a commit that referenced this issue Jun 10, 2020
* Patch for #57.

* Update PopupHighscores.as

Break loop early if not 10 items, also set maxPage.

* Update PopupHighscores.as

Assume we have over 20 billion entries just in case.
Zageron added a commit that referenced this issue Jun 10, 2020
@Zageron Zageron closed this as completed Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants