Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight options menu button when in corresponding screen #9

Closed
TCHalogen opened this issue Apr 11, 2020 · 1 comment · Fixed by #37
Closed

Highlight options menu button when in corresponding screen #9

TCHalogen opened this issue Apr 11, 2020 · 1 comment · Fixed by #37
Assignees
@TCHalogen
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TCHalogen
Copy link
Contributor

TCHalogen commented Apr 11, 2020 •
edited

Request
A simple but potentially effective change for newer players who might not know their way along the options menu, as well as an effective QoL change - highlight the button corresponding to the part of the options menu that the user is in.

Even if the options menu is due for a UI overhaul, this change shouldn't be difficult to implement due to there being event handling on the click of a button (to display the menu contents itself).

Images
https://i.imgur.com/EpRyRWm.png
https://i.imgur.com/NwB86Pu.png
@TCHalogen TCHalogen added the enhancement New feature or request label Apr 11, 2020
@maxproske maxproske added the good first issue Good for newcomers label Apr 28, 2020
@TCHalogen TCHalogen self-assigned this May 17, 2020
@TCHalogen
Copy link
Contributor Author

Yoink.

@Zageron Zageron linked a pull request May 19, 2020 that will close this issue
Highlight options menu button when in corresponding screen (#9) #37
Merged
Zageron added a commit that referenced this issue May 31, 2020
@TCHalogen @maxproske @Zageron
Highlight options menu button when in corresponding screen (#9) (#37)
2168ccb 
Co-authored-by: Max Proske <max@mproske.com>
Co-authored-by: Zageron <hello@adambryant.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TCHalogen TCHalogen

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight options menu button when in corresponding screen (#9)
2 participants
@maxproske @TCHalogen