Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Judgements #141

Closed
3 tasks done
Zageron opened this issue Apr 8, 2022 · 1 comment
Closed
3 tasks done

Judgements #141

Zageron opened this issue Apr 8, 2022 · 1 comment
Assignees
@Zageron
Labels
gameplay Gameplay related changes
Milestone
MVP

Comments

@Zageron
Copy link
Member

Zageron commented Apr 8, 2022 •
edited

  • Receptors
  • Misses
  • Sane judge window
@Zageron Zageron self-assigned this Apr 8, 2022
@Zageron Zageron changed the title Chart: Add rudimentary key inputs and hit detection. Gameplay: Add rudimentary key inputs and hit detection. Apr 8, 2022
@Zageron Zageron added gameplay Gameplay related changes mvp labels Apr 8, 2022
@Zageron Zageron changed the title Gameplay: Add rudimentary key inputs and hit detection. Add rudimentary key inputs and hit detection. Apr 8, 2022
@Zageron Zageron added this to the mvp milestone Apr 9, 2022
@Zageron Zageron removed the mvp label Apr 9, 2022
@Zageron Zageron changed the title Add rudimentary key inputs and hit detection. Judgements Jul 30, 2022
@Zageron
Copy link
Member Author

Zageron commented Aug 4, 2022

The last step of this task is making sure that the judge window is a concrete value, regardless of the scroll speed.
Currently it is a constant 200ms out of 1800ms time on screen.
What should be used instead is a variant value of note_timestamp + 118 (the average judge window).
That way when the note passes out of range of the view it will be considered missed.

Another alternative is to use a different view method for the judgement system, in which a queue is used. When a note expires it can be removed from the queue and new notes could be added to the queue. This is more processing time however.

@Zageron Zageron closed this as completed Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Zageron Zageron

Labels
gameplay Gameplay related changes
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@Zageron