Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Problem with google OpenId - escaped namespace in OpenId.isValid() #68

Open
kozak opened this Issue · 3 comments

2 participants

@kozak

the fix is to unquote the get arguments you get from the request:

def complete(self):
args = dict(self.request.GET.items())
args_unquoted = {}
for key, value in args.iteritems():
args_unquoted[key] = urllib2.unquote(value)
self.result = self.consumer.complete(
args_unquoted,
'http%s://%s%s' % (_https(), Site.objects.get_current(),
self.request.path)
)

@flashingpumpkin

Not sure what's going on. I just tested it out with OpenID + Google without having to tamper with any quoting.

@kozak

Will have to investigate when I get some time so I can get you a good test case

@flashingpumpkin

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.