Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with google OpenId - escaped namespace in OpenId.isValid() #68

Open
kozak opened this issue Apr 1, 2011 · 3 comments
Open

Problem with google OpenId - escaped namespace in OpenId.isValid() #68

kozak opened this issue Apr 1, 2011 · 3 comments

Comments

@kozak
Copy link

kozak commented Apr 1, 2011

the fix is to unquote the get arguments you get from the request:

def complete(self):
args = dict(self.request.GET.items())
args_unquoted = {}
for key, value in args.iteritems():
args_unquoted[key] = urllib2.unquote(value)
self.result = self.consumer.complete(
args_unquoted,
'http%s://%s%s' % (_https(), Site.objects.get_current(),
self.request.path)
)

@flashingpumpkin
Copy link
Owner

Not sure what's going on. I just tested it out with OpenID + Google without having to tamper with any quoting.

@kozak
Copy link
Author

kozak commented Apr 28, 2011

Will have to investigate when I get some time so I can get you a good test case

@flashingpumpkin
Copy link
Owner

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants