Missing return value in SQL Backend?

[lord-alfred]

As I already wrote - I am new to golang (thank you for guerrilla - I’m learning from it!).

Perhaps there is not enough return value here:

go-guerrilla/backends/p_sql.go

Lines 117 to 120 in 15a3295

	if execErr != nil {
	Log().WithError(execErr).Error("There was a problem the insert")
	}
	return

Maybe:

	if execErr != nil {
		Log().WithError(execErr).Error("There was a problem the insert")
		return execErr
	}

Because calling this method will always return nil:

go-guerrilla/backends/p_sql.go

Lines 259 to 262 in 15a3295

	err := s.doQuery(1, db, stmt, &vals)
	if err != nil {
	return NewResult(fmt.Sprint("554 Error: could not save email")), StorageError
	}

But I see from the logs that everything works as it should! But in Python there is such a rule: Explicit is better than implicit.

Maybe it should be explicitly prescribed here?

PS: It is very inconvenient that errors in this place are written to various log files.
Error "There was a problem the insert" is always written at main.log, and "554 Error: could not save email" is always written at server.log.

[andreypanin]

Hello @lord-alfred,

The return on line 120 is called naked and is possible because the function got a named return value execErr on line 100. Since error is an interface type, it defaults to nil at the start of the function. And this value is exactly what will be returned on line 120.