Make BaseView compatible with Flask 2.2.x #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `as_view` method in the latest Flask version doesn't receive any positional argument, since this change: pallets/flask@6e23239 This patch makes the code in base compatible with this new version, trying to call the view with the positional argument if present and in other case it's passed as `cls` named argument. This fixes the `test_nested_flask_views` that was broken for this version.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 3, 2023
https://build.opensuse.org/request/show/1046499 by user dgarcia + dimstar_suse - Add fix-tests.patch to make tests compatible with latest Flask release * gh#flask-admin/flask-admin#2309 * gh#flask-admin/flask-admin#2316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as_viewmethod in the latest Flask version doesn't receive any positional argument, since this change:pallets/flask@6e23239
This patch makes the code in base compatible with this new version, trying to call the view with the positional argument if present and in other case it's passed as
clsnamed argument.This fixes the
test_nested_flask_viewsthat was broken for this version.