New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendored Moment.js is vulnerable to directory traversal and redos attacks #2386

Closed

jamesliu4c opened this issue Oct 5, 2023 · 2 comments · Fixed by #2387

Contributor

jamesliu4c commented Oct 5, 2023 •

edited

Loading

Here is a summary of the vulnerabilities: https://security.snyk.io/package/npm/moment/2.22.2

The Changelog for Moment looks like it does not introduce breaking changes betwen 2.22.2 and 2.29.4.

My suggestion is to update replace the vendored Moment in all of the template versions: 2, 3, and 4, and then update the templates.

Also, I can PR this change if that is acceptable.

Shookit commented Oct 5, 2023

Moment.js appears to be specified at the following locations:

https://github.com/flask-admin/flask-admin/blob/master/flask_admin/templates/bootstrap2/admin/base.html#L71
https://github.com/flask-admin/flask-admin/blob/master/flask_admin/templates/bootstrap3/admin/base.html#L85
https://github.com/flask-admin/flask-admin/blob/master/flask_admin/templates/bootstrap4/admin/base.html#L84

Contributor Author

jamesliu4c commented Oct 5, 2023

alanhamlett linked a pull request

that will close this issue

Bump vendored moment.min.js to 2.29.4 #2387

Merged

alanhamlett closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment