Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would it make sense to automatically group unit tests by the endpoint that they test? #42

Closed
mircealungu opened this issue Sep 23, 2017 · 7 comments
Assignees

Comments

@mircealungu
Copy link
Member

i'd like to talk about this in our next meeting

@kloostert
Copy link
Member

The most recent commit in the development branch contains an implementation of the functionality for unit test results grouping by the endpoints that they hit. Running the Dashboard on a very simple app results in the following 'Test Monitor' page:
screenshot
It shows two simple endpoints, with their corresponding color in the header.
On clicking the header, the unit test results for that specific endpoint are shown (like for 'static').
Is this more or less what you had in mind?

@mircealungu
Copy link
Member Author

that is cool @kloostert !

do i have to migrate the DB/code in any way
to try it out on the server? or can i simply
pull the latest version on the dev branch?

what are main and static in the image?

the run-times in the table ... are they
for the test or for the endpoint?

@kloostert
Copy link
Member

Migration of the DB should be done automatically by the code.

But, when running the dashboard of the development branch on the server, the 'Test Monitor' page will be inaccessible, since it will not yet have any grouped unit test data (which it should receive from Travis).
Maybe it's an idea to set up the Travis part first, such that this data can be provided?

In the image, 'main' and 'static' are endpoint names of the small Flask app that I used for testing purposes.

The run-times in the table are left untouched and so they are the same as before (those are execution times for the tests).

@kloostert
Copy link
Member

I can do the Travis setup and configuration for this new functionality, but it seems that the current build of Zeeguu-API is not able to get through the setup phase. The Travis log says:
error: newspaper3k 0.2.5 is installed but newspaper3k==0.2.2 is required by {'watchmen'}
The command "python setup.py develop" failed and exited with 1 during .

@mircealungu
Copy link
Member Author

mircealungu commented Oct 11, 2017 via email

@FlyingBird95
Copy link
Member

Is this issue resolved now? @mircealungu @kloostert

@mircealungu
Copy link
Member Author

Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants