Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbox: Mounted snapshots are being gc'ed which bricks the toolbox #1399

Closed
daMupfel opened this issue Mar 22, 2024 · 4 comments
Closed

toolbox: Mounted snapshots are being gc'ed which bricks the toolbox #1399

daMupfel opened this issue Mar 22, 2024 · 4 comments
Labels
kind/bug Something isn't working

Comments

@daMupfel
Copy link

Description

This is the related issue to PR flatcar/toolbox#9. I wasn't sure if toolbox PRs will directly be looked up or if you guys want an issue to track it.

The toolbox uses ctr under the hood if available. The 'ctr image mount' command by default adds a 1 day lease on the created snapshot that is mounted as the upperdir. Therfore the snapshot will be gc'ed and the toolbox not function correctly anymore as the upperdir does not longer exist.

Impact

The toolbox bricking itself which requires an unmount to fix it.

Environment and steps to reproduce

When ctr is available on the host.

  1. Create a toolbox and edit some files
  2. Wait for a day
  3. Toolbox is now broken

Expected behavior

The toolbox to work.

Additional information

Can be found with PR: flatcar/toolbox#9

@daMupfel daMupfel added the kind/bug Something isn't working label Mar 22, 2024
@daMupfel daMupfel changed the title toolbox: Mounted snapshots arebeing gc'ed which bricks the toolbox toolbox: Mounted snapshots are being gc'ed which bricks the toolbox Mar 22, 2024
@jepio
Copy link
Member

jepio commented Mar 22, 2024

HI @daMupfel, I saw your PR but it's been a busy time, sorry for not getting back to you with a review. I'll post my question there.

@daMupfel
Copy link
Author

No worries, just wasn't sure if you guys prefer to have a tracking issue for it, since not much is happening in the toolbox repo in general :).

Thank you very much for looking at this!

Regards,

David

@jepio
Copy link
Member

jepio commented Mar 27, 2024

Merged and backported to all channels. Will be released in april.

@jepio jepio closed this as completed Mar 27, 2024
@daMupfel
Copy link
Author

Thank you very much :) 🙏!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Development

No branches or pull requests

2 participants