You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I stumbled on this -- if you make a simple app using flatgeobuf that doesn't depend directly on reqwest@0.11.0, it will fail to handle https urls with this error message:
Error: http error `error sending request for url (https://blah/blah/blah.fgb): error trying to connect: invalid URL, scheme is not http`
That error originates in hyper. I think the issue is that http-range-client has an optional dependency on reqwest and so without that, you'll get a client that has no support for HTTPS. That's...really odd. I'd suggest either:
document clearly that HttpFgbReader will not read HTTPS urls unless you add an explicit dependency on the same version of request that flatgeobuf's http-range-client depends on, or
add a tls or http feature to flatgeobuf and document that in the README.
The text was updated successfully, but these errors were encountered:
I agree. Rather than add more documentation, I think it's preferable to just do what people expect to be done anyway. For the same reason reqwest enables https by default, so should http-range-client. People fully expect an http client to be able to speak tls by default without needing to read documentation and pass special options.
I stumbled on this -- if you make a simple app using
flatgeobuf
that doesn't depend directly onreqwest@0.11.0
, it will fail to handlehttps
urls with this error message:That error originates in
hyper
. I think the issue is thathttp-range-client
has an optional dependency onreqwest
and so without that, you'll get a client that has no support for HTTPS. That's...really odd. I'd suggest either:HttpFgbReader
will not read HTTPS urls unless you add an explicit dependency on the same version of request thatflatgeobuf
'shttp-range-client
depends on, orThe text was updated successfully, but these errors were encountered: