Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Wayland version on selected shells other than Phosh? #2

Open
alpabrz opened this issue Jul 20, 2022 · 9 comments
Open

Use Wayland version on selected shells other than Phosh? #2

alpabrz opened this issue Jul 20, 2022 · 9 comments

Comments

@alpabrz
Copy link
Contributor

alpabrz commented Jul 20, 2022

As defined in this line, Quadrix starts only on Phosh per default in its Wayland session. I've also tried this Flatpak out in its Wayland version (by using the arguments --enable-features=UseOzonePlatform --ozone-platform=wayland) on

  • SXMO's Wayland version (based on Sway, on a Pine64 PinePhone) (XDG_SESSION_DESKTOP=swmo)
  • KDE Neon Unstable (in a VM) (XDG_SESSION_DESKTOP=KDE)

... and it seems to work quite nice.
However, on Fedora Workstation 35 w/ GNOME (in a VM) there was no window decoration, so I don't think it should be enabled there.

If there is no pressing reason to not use the Wayland version on selected graphical shells other than Phosh, I would propose to extend it to those other, tested platforms mentioned.

@alpabrz alpabrz changed the title Use Wayland version on shells other than Phosh? Use Wayland version on selected shells other than Phosh? Jul 20, 2022
@alpabrz
Copy link
Contributor Author

alpabrz commented Jul 20, 2022

Sorry, opened that issue a little bit prematurely and needed to make some edits.

@alariej
Copy link
Collaborator

alariej commented Aug 15, 2022

Sorry I've just now seen your issue! Not quite sure why, but I didn't get any email notification from Github.

Thanks for looking at this. As you suggest, I'll change the condition to enable Wayland on SXMO and KDE desktops. I had tested Fedora+Gnome and also saw the missing window decorations, so that's why it was only enabled for Phosh so far.

I'm working on some minor bugs and changes at the moment, so I expect a new release at some point next week.

@alariej
Copy link
Collaborator

alariej commented Aug 15, 2022

Hi, can you confirm that the XDG_SESSION_DESKTOP identifier for SXMO is "swmo", and not "sxmo"? I can't find any reference to this. Thanks.

@alariej
Copy link
Collaborator

alariej commented Aug 19, 2022

OK got it, SWMO is SXMO for Wayland.

https://linmob.net/playing-with-swmo/

Will be in the next Flatpak release.

@alariej
Copy link
Collaborator

alariej commented Sep 13, 2022

@alpabrz I'll close the issue as your change has been merged. Let me know if you could test it successfully.

- if [ "${XDG_SESSION_TYPE}" == "wayland" ] && [ "${XDG_SESSION_DESKTOP}" == "phosh" -o "${XDG_SESSION_DESKTOP}" == "swmo" -o "${XDG_SESSION_DESKTOP}" == "kde" ]; then

@alariej alariej closed this as completed Sep 13, 2022
@alpabrz
Copy link
Contributor Author

alpabrz commented Sep 14, 2022

Hey, sorry for the late response, I was in vacation... It works great now in the latest release, thanks for the fix 👍

@alariej
Copy link
Collaborator

alariej commented Oct 26, 2022

Hi @alpabrz, I am thinking of disabling Wayland for Phosh due to the unresolved keyboard bug (no possibility to type "q", "k", "@" on the on-screen keyboard) in Electron/Wayland:

https://gitlab.gnome.org/World/Phosh/squeekboard/-/issues/244

I guess you are not using Quadrix on a Linux mobile phone (i.e. PinePhone), so you probably didn't come across this bug, but let me know if you ever hear of a workaround that would allow to use Quadrix with Wayland on mobiles.

Thanks.

@alariej alariej reopened this Oct 27, 2022
@alpabrz
Copy link
Contributor Author

alpabrz commented Nov 2, 2022

First, thanks for the followup!

I am thinking of disabling Wayland for Phosh due to the unresolved keyboard bug

Yes, I've noticed this bug while testing, but wasn't sure whether to report it here since it is an upstream issue. And as far as I remember, the X11 version had some problems on Phosh too so I hesitated. Probably should've just mentioned it here.

I guess you are not using Quadrix on a Linux mobile phone

I've used it for a brief period on SWMO, didn't notice input issues but also didn't test it thoroughly enough maybe. They use a different on-screen keyboard (wvkbd), so that may be an explanation why.

On Plasma Mobile, last time I tested, their OSK didn't even show up (when tapping into a text field) so Quadrix was, unfortunately, unusable there.

My PinePhone is currently broken, but replacement parts already arrived. Just need some time to put them together, but maybe next weekend I'll find some time. Then I can test again on the aforementioned desktop environments and report the results.

@alariej
Copy link
Collaborator

alariej commented Nov 2, 2022

Hi, I went ahead and disabled Wayland for Phosh, so the new releases of Quadrix don't launch using the Ozone switches, The app looks blurry on the PinePhone, but at least the OSK works. Let's hope the upstream issue (text-input-v3 support in Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/3750452) gets solved soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants