Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 build #63

Open
baarkerlounger opened this issue May 24, 2021 · 15 comments
Open

Aarch64 build #63

baarkerlounger opened this issue May 24, 2021 · 15 comments
Labels
help wanted Extra attention is needed

Comments

@baarkerlounger
Copy link

The aarch64 build seems to be several versions (1.7.0) behind the x86_64 builds (1.26.4).

@hfiguiere
Copy link

Does it even work ? Current build is x86_64 only from a .deb package.

@hfiguiere
Copy link

See f3e64e8 and #16

@baarkerlounger
Copy link
Author

Currently running 1.7.0 on a PinePhone (ARM64) running Mobian and installed via flatpak - that works fine. Just no updates for it since then obviously.

@ghisvail
Copy link
Collaborator

There has been an attempt to switch back to a source build in #55

@hfiguiere
Copy link

I thought electron was about to make application portable...

#sarcasm

@ghisvail
Copy link
Collaborator

I thought electron was about to make application portable...

Truth be told Electron has got its issues, but often it's the insanity of JavaScript packaging which is at fault. There are very little projects I know where offline builds are possible without a non-trivial amount of patching.

@alistair23
Copy link

Bitwarden now builds ARM binaries, see bitwarden/desktop#1095

It should be possible to just use those .debs once a release happens

@hfiguiere
Copy link

patch got revert. It seems that again, github is the blocker.

Now we do have builder for aarch64 on flathub, so building from source could be a solution.

@hfiguiere
Copy link

which I know was also reverted.

@locness3
Copy link

locness3 commented Apr 9, 2022

What's the status of this?

@ghisvail
Copy link
Collaborator

ghisvail commented Apr 9, 2022 via email

@julianfairfax
Copy link

There has been an attempt to switch back to a source build in #55

Was the attempt unsuccessful?

@ghisvail
Copy link
Collaborator

ghisvail commented Aug 3, 2022

Considering the upstream repository has been restructured, there is a high chance that the last attempt of building from source needs a rework.

@alexhaydock
Copy link

What is needed for #55 to get merged?

I notice that the aarch64 build is reported as existing by Flatpak and it does actually download on an aarch64 host, but it doesn't run:

user@asahi:~$ flatpak run com.bitwarden.desktop 
/app/bin/bitwarden: line 2:     3 Segmentation fault      (core dumped) npm start --prefix=/app/main

It does look like the version of Node that's being packaged here is correctly aarch64 so I'm not sure why the immediate segfault, but I didn't look into it too closely given that #55 still seems to be open:

user@asahi:~$ file /var/lib/flatpak/app/com.bitwarden.desktop/aarch64/stable/9eaa33ff7890ee62da3718e148774220176666364adabeb9bf7502d7f6a7da29/files/bin/node
/var/lib/flatpak/app/com.bitwarden.desktop/aarch64/stable/9eaa33ff7890ee62da3718e148774220176666364adabeb9bf7502d7f6a7da29/files/bin/node: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, stripped

@hfiguiere
Copy link

What is needed for #55 to get merged?

Probably the maintainers. Now if somebody can rebase it to trigger a new build that can be tested and it is tested to work, I'd be happy to press the merge button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants