flathubbot not automatically merging

[TheEvilSkeleton]

We got an MR from flathubbot, but it still needed manually merging, see flathub/com.brave.Browser#23.

However, I've enabled automerging, see com.brave.Browser's flathub.json.

I'm not sure exactly what the issue is. Perhaps I wrote it wrongly?

[gasinvein]

Yes, the automerge-flathubbot-prs property in your flathub.json is invalid, should be true instead of [ true ] (boolean instead of list).

[TheEvilSkeleton]

{
  "only-arches": [
    "x86_64"
  ],
  "automerge-flathubbot-prs":
    true
}

Like this?

[gasinvein]

Almost, the new line is redundant (I'm not sure if it'll result in parse error or not, but better not adding it).

[TheEvilSkeleton]

{
  "only-arches": [
    "x86_64"
  ],
  "automerge-flathubbot-prs": true
}

This should be right, right?

[gasinvein]

Looks fine.

[TheEvilSkeleton]

Thank you.

[TheEvilSkeleton]

@gasinvein looks like I had to manually merge again: flathub/com.microsoft.Edge#23. Should this be reopened?

[wjt]

This script only auto-merges if it finds an existing PR, with passing CI. IIRC it runs hourly.