Consistently default stable-only to true #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Codepath where |
Previously, gnomechecker would default stable-only to true, but anityachecker and pypichecker defaulted it to false. true is the sensible default, in my opinion: it is more common to want stable release only than it is to track prereleases. Update the test suite to exercise all three paths: true, false and unset. (We don't actually make any assertions about what the default is; it is hard to do so without a mock anitya.)
wjt
force-pushed
the
stable-only-should-default-to-true
branch
from
a3dc51f
to
6faaa82
Compare
|
How's that? |
|
Now the codepath where neither constraints are set, nor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, gnomechecker would default stable-only to true, but
anityachecker and pypichecker defaulted it to false.
true is the sensible default.