Add “Flatpak” to About dialog

[ovari]

Please show that the version of Thunderbird is a “Flatpak”, via Thunderbird Menu Bar → Help → About Thunderbird. Thank you

Image below is from LibreOffice’s About dialog with green added showing “Flatpak version”.

Recommend not having “version” to save translation just “Flatpak”, to be similar to Thunderbird Daily, i.e. Change “62.0a1 (2018-06-17) (64-bit)” to “52.8.0 Flatpak (64-bit)”.

[AdrianKoshka]

How do I do this? Can something like this be done via the mozconfig file?

[ovari]

Would looking at the LO scripts work?

[AdrianKoshka]

I think it's done in their build system, and not via patches.

"./autogen.sh --prefix=/run/build/libreoffice/inst --with-distro=LibreOfficeFlatpak --disable-symbols $(if test "$(uname -m)" = aarch64; then printf %s --disable-pdfium; fi)"

[barthalion]

What is the use case?

[AdrianKoshka]

I was also going to ask this, I don't see why we need to distinguish the flatpak version of Thunderbird from non-flatpaked, but that's just my opinion.

[ovari]

A use case is when there are bug reports, specifying the source of the version can help reproduce, determine the cause and hence fix errors.

[ovari]

@AdrianKoshka You wrote "I think it's done in their build system, and not via patches."
Does that mean code modifications need to happen in the Thunderbird core code?

[AdrianKoshka]

Does that mean code modifications need to happen in the Thunderbird core code?

Yes.

A use case is when there are bug reports, specifying the source of the version can help reproduce, determine the cause and hence fix errors.

I suppose this might be a helpful use case.

[ovari]

https://bugzilla.mozilla.org/show_bug.cgi?id=1470730

[nedrichards]

@ovari this is exactly the sort of thing that can be added and improved when upstream has flatpak as an official distribution source and sees value in it. If that's true then everything else comes by default.

But more generally Flathub isn't a place for giant modifications and lots of patches. It's for distributing stable software from developers. Changes and requests should go on upstream, so thanks for filing a bug there.