Add SDL_sound module

[AsciiWolf]

Please, consider adding SDL_sound module. It is required, for example, by compressed audio feature of DOSBox.

[TingPing]

Patch welcomed.

[AsciiWolf]

Yeah, I'll try to make a PR when I have some time. Unfortunately, I am quite busy lately. :-(

[bam80]

Maybe we should start with adding SDL2, what do you think @AsciiWolf ?

[AsciiWolf]

@bam80 I don't think that the stable DOSBox release supports SDL2. And there are more projects on Flathub that still use SDL1.

[TingPing]

SDL2 is in the runtime...

[bam80]

SDL_sound code is managed by Mercurial, which is unsupported by Flatpak.
The latest officially released binaries and source doesn't contain latest release.

Any advise how to deal with the source?

[jurf]

According to the Mercurial web interace, the newest release is 1.0.3, which is available there: https://icculus.org/SDL_sound/downloads/SDL_sound-1.0.3.tar.gz

[bam80]

@jurf no, it's too old.
Hope http://hg.icculus.org/icculus/SDL_sound/archive/final-lgpl-revision.tar.bz2 give us stable content..

[TingPing]

no, it's too old.
Hope http://hg.icculus.org/icculus/SDL_sound/archive/final-lgpl-revision.tar.bz2 give us stable content..

It just looks like he never made a release. That tag is clearly just before a re-license not a release.

Honestly probably something to discuss with the maintainer himself.

@AsciiWolf In the short term maybe just bundle it if nothing else is using it.

[bam80]

If so, let's ask @rcgordon himself.
I already send an email to him, but got no response so far. So I just going to use the link above if nothing changes..

[icculus]

Doing an official release because FlatPak doesn't support Mercurial is not a good reason to do an official release.

SDL_sound 2 (what the default branch will eventually become) isn't ready, and the stable-1.0 branch is a total mess that needs a lot of work to be release-ready.

So this is a stupid question: how hard would it be to add Mercurial support to FlakPak? I could be interested in patching that in if that solves this specific problem at the same time.

[jurf]

@bam80 um, well Arch and Fedora both use 1.0.3? Though I have no expertise on this topic; I’m unsubscribing, sorry for the noise.

[TingPing]

Doing an official release because FlatPak doesn't support Mercurial is not a good reason to do an official release.

That isn't the reason, the reason is Flathub targets stable releases. Taking a random snapshot from the repo is not ideal.

[TingPing]

So this is a stupid question: how hard would it be to add Mercurial support to FlakPak? I could be interested in patching that in if that solves this specific problem at the same time.

It would be something like this: flatpak/flatpak-builder@4510aa2

Might look like a bit but its mostly boilerplate.

[icculus]

That isn't the reason

(Sorry, someone emailed me about this shortly after this issue was opened and said "for Flatpak's build of SDL_sound I would like to checkout stable-1.0 branch. The problem is, Flatpak doesn't support Mercurial (yet?)." ... I assumed it was in relation to this!)

[bam80]

@rcgordon it was my email.

SDL_sound 2 (what the default branch will eventually become) isn't ready, and the stable-1.0 branch is a total mess that needs a lot of work to be release-ready.

So what will be the conclusion?
Just use latest release https://icculus.org/SDL_sound/downloads/SDL_sound-1.0.3.tar.gz
which is more than 10 years old already?

[barthalion]

Is there anything actually broken in the latest release? Not saying Mercurial support wouldn't be useful, I'm just a little bit out of the loop about the reason behind this issue.

[bam80]

@barthalion no, it's just about age of the latest release which is a bit scary

[bam80]

Failed to download sources: port 443: Connection refused

[bam80]

@AsciiWolf In the short term maybe just bundle it if nothing else is using it.

Agree, and it was bundled with DOSBox in flathub/com.dosbox.DOSBox#13.
So we could close this if no other demand.