Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support non-desktop components #53

Closed
bilelmoussaoui opened this issue Nov 6, 2020 · 14 comments · Fixed by #1676
Closed

support non-desktop components #53

bilelmoussaoui opened this issue Nov 6, 2020 · 14 comments · Fixed by #1676

Comments

@bilelmoussaoui
Copy link
Contributor

Currently, the api endpoints are desktop-app specific. We should expose at least cli, extensions & sdk's. This also would be a step forward to support displaying extensions of an application.

@tchx84
Copy link
Contributor

tchx84 commented Nov 11, 2020

Currently, the api endpoints are desktop-app specific. We should expose at least cli, extensions & sdk's. This also would be a step forward to support displaying extensions of an application.

How do you think the API should look like?

Here's the thing:

  1. CLI tools are just regular apps without appstream.xml nor .desktop.

Should we expose CLI tools under the same apps endpoint, and simply extend the details struct with a "cli: true" field? Or should we provide a separate endpoint? My first thought is to go for the first option as it would simplify a lot of things, e.g. we ca re-use the other existing endpoints like search.

  1. Extensions and SDKs are both runtimes. Any clues on how we want to expose these? Are these complementary to apps? e.g. they will be displayed along with apps, or should the be presented / searchable independently ?

@barthalion
Copy link
Member

Some more questions: appstream-glib is picky about console applications shipping icons. We need that changed too.

@razzeee
Copy link
Contributor

razzeee commented Nov 27, 2021

Extensions are now exposed via the summary endpoint or is there more, that I'm not aware of?
So we could show them on the detail page, would there be an action we can take?

Also is there more data then this? A nicer name for e.g.?

   "extensions": {
      "tv.kodi.Kodi.Debug": {
        "directory": "lib/debug",
        "autodelete": "true",
        "no-autodownload": "true"
      }
    },

@razzeee
Copy link
Contributor

razzeee commented Dec 1, 2021

Some small changes make this work on our end

image

image

This is only with console-applications in addition. 18 apps more currently, so I checked all, they work fine, besides the logo. Which we could just not show on the detail page and use the flathub logo/a placeholder on the listings.

@bilelmoussaoui
Copy link
Contributor Author

use the flathub logo/a placeholder on the listings.

I don't think that's a good approach. People will end up confusing what the app is about and think it's an "offical Flathub app" or whatever.

I think CLI apps needs a different design/categories in general; different from desktop apps.

@razzeee
Copy link
Contributor

razzeee commented Dec 2, 2021

I don't think that's a good approach. People will end up confusing what the app is about and think it's an "offical Flathub app" or whatever.

makes sense for the flathub logo, but having a generic package logo shouldn't cause that problem. we could also overlay the app name onto the image, to help with people thinking they might be the same.

I think CLI apps needs a different design/categories in general; different from desktop apps.

While that would solve the problem, I think it would create new ones, which I think would be worse. Search for example would need to have two listings with both of those different designs.

That being said, obviously, having the logos in the first place is the best approach

@razzeee
Copy link
Contributor

razzeee commented Dec 6, 2021

This also needs something like a tag on the detail page, to let users easily understand, that it's a cli app

@bilelmoussaoui
Copy link
Contributor Author

This also needs something like a tag on the detail page, to let users easily understand, that it's a cli app

The issue here is that it's not only about CLI apps (unless that's explicitly your goal) but we also have SDKs/Runtimes/Extensions that needs to be showed somehow :)

@razzeee
Copy link
Contributor

razzeee commented Dec 7, 2021

I think it makes sense to break this up. We probably want them to show up differently, especially extensions. And it might be worth it getting the parts in, that we can already solve.

@abique
Copy link

abique commented Mar 17, 2022

I think it makes sense to break this up. We probably want them to show up differently, especially extensions. And it might be worth it getting the parts in, that we can already solve.

Yes you're right.
In regards to Digital Audio Workstation, I could even imagine a dedicated category for VST/LV2 plugins.
As of today there aren't so many VST plugins on flathub, but if it takes off, it can really grow massively.

@razzeee
Copy link
Contributor

razzeee commented Jul 10, 2023

@bilelmoussaoui was this about the API explicitly? because if so, this should be fixed.

@bilelmoussaoui
Copy link
Contributor Author

@bilelmoussaoui was this about the API explicitly? because if so, this should be fixed.

I opened this when I started working on the frontend and thought of supporting non-desktop apps.

@razzeee
Copy link
Contributor

razzeee commented Jul 10, 2023

Okay, so we can only close this after we show console apps in some way :)

@razzeee
Copy link
Contributor

razzeee commented Jul 12, 2023

This might still need a tag or info on the detail page, but let's see how confused users are without.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants