Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing uncaught exception handler on Windows. #126

Merged
merged 1 commit into from
May 30, 2012
Merged

Fixing uncaught exception handler on Windows. #126

merged 1 commit into from
May 30, 2012

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Apr 11, 2012

The lack of process.getuid and process.getgid cause it to throw an exception. An exception in the uncaught exception handler is... not good.

The lack of `process.getuid` and `process.getgid` cause it to throw an exception. An exception in the uncaught exception handler is... not good.
@domenic
Copy link
Contributor Author

domenic commented May 7, 2012

Is there anything else I should do to get this accepted?

@Marak
Copy link
Contributor

Marak commented May 28, 2012

I think this is OK.

Is there an equivalent value that Windows could return opposed to just null ?

@domenic
Copy link
Contributor Author

domenic commented May 28, 2012

I suppose process.env.USERNAME could substitute for uid? It would be misnamed though. And Windows does have a concept similar to Unix groups, but they do not seem to be exposed to Node in any way, and seem sufficiently different that I'm not sure how you would fit them into a gid field.

Marak added a commit that referenced this pull request May 30, 2012
[fix] [windows] Fixing uncaught exception handler on Windows.
@Marak Marak merged commit e55fe5e into winstonjs:master May 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants