Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo generator doesn't include .workspace versions #348

Closed
ImUrX opened this issue Feb 13, 2023 · 1 comment · Fixed by #349
Closed

cargo generator doesn't include .workspace versions #348

ImUrX opened this issue Feb 13, 2023 · 1 comment · Fixed by #349
Labels

Comments

@ImUrX
Copy link

ImUrX commented Feb 13, 2023

flatpak-builder version

1.2.3

Linux distribution and version

NixOS 23.05

Affected flatpak-builder tool

cargo/flatpak-cargo-generator.py

flatpak-builder tool cli args

No response

Source repository URL

https://github.com/tauri-apps/plugins-workspace/blob/dev/plugins/window-state/Cargo.toml

Flatpak-builder manifest URL

https://github.com/flathub/dev.slimevr.SlimeVR

Description

When trying to build a git dependency that is inside a workspace, cargo can take into account the root of the workspace for versions. The generator doesnt take that into account.

@ImUrX ImUrX added the bug label Feb 13, 2023
@gasinvein
Copy link
Member

gasinvein commented Feb 13, 2023

This doesn't seem to work with cargo vendor either; since the sources generator aims to replicate Cargo's native vendoring mechanism, I'm not sure if there is a way we can make this work.

You can test if vendoring is possible for your project like this:
(run these in a clean source tree of the project)

mkdir .cargo
cargo vendor --locked --versioned-dirs > .cargo/config
cargo build --offline

Overall, this looks like the same issue as rust-lang/cargo#11192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants