Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate replacing custom XML parsing with libxml2 #568

Open
TingPing opened this issue Oct 23, 2023 · 1 comment
Open

Investigate replacing custom XML parsing with libxml2 #568

TingPing opened this issue Oct 23, 2023 · 1 comment
Labels
help wanted

Comments

@TingPing
Copy link
Member

Currently in builder-utils.c there is semi-custom parsing built upon GMarkupParser.

Since we already depend on libxml2 indirectly through libappstream we might as well use a more robust parser.
@TingPing TingPing mentioned this issue Oct 23, 2023
Merged
@hfiguiere
Copy link
Contributor

Actually it already directly depends on libxml.

https://github.com/flatpak/flatpak-builder/blob/main/src/meson.build#L58C1-L58C47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hfiguiere @TingPing