Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fd leak prevents removable media from being ejected #487

Closed
ptomato opened this issue May 18, 2020 · 7 comments
Closed

fd leak prevents removable media from being ejected #487

ptomato opened this issue May 18, 2020 · 7 comments

Comments

@ptomato
Copy link

ptomato commented May 18, 2020

I opened a file residing on removable media, through the portal, in the org.mozilla.Thunderbird app. Even after closing the app I couldn't eject the drive because it was "busy".

relevant entry from lsof (repeated many times):

xdg-docum  7925 14911 pool-/usr  ptomato   17u      REG                8,2 (file size redacted)       2282 /run/media/ptomato/(filename redacted)

Process 7925 is:

   7925 ?        Ssl    0:23 /usr/libexec/xdg-document-portal
@sophie-h
Copy link
Contributor

sophie-h commented Jul 9, 2020

Very similar to #509. It seems like somehow nobody cared about closing fds returned by g_unix_fd_list_append()

@matthiasclasen
Copy link
Contributor

I will take a look at this soon

@hadess
Copy link
Contributor

hadess commented Sep 23, 2020

#530 might be the fix (on top of the other fixes in #515).

@orowith2os
Copy link

@ptomato can you reproduce this now?

@ptomato
Copy link
Author

ptomato commented Oct 3, 2023

I don't know if I recreated the exact circumstances, but this does not seem to be a problem any longer in xdg-desktop-portal 1.16.0.

@GeorgesStavracas
Copy link
Member

Thanks. Let's assume it was fixed then, but if you spot it again, please reopen

@hfiguiere
Copy link
Collaborator

I thought this was #689

Looks a lot like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triaged
Development

No branches or pull requests

7 participants