Exception when input is not a valid date

[Phyks]

Reproduction Link

https://jsfiddle.net/tj2Lo4z7/

Your Environment

• flatpickr version used: 4.1.4

Hi,

When putting anything (but not a valid date) in the input field (with allowInput: true) and pressing "Enter", an exception is thrown in the dev console:

Error: Invalid date provided: toto
Stack trace:
parseDate@http://localhost:9876/main.js:80266:38
setSelectedDate@http://localhost:9876/main.js:80106:30
setDate@http://localhost:9876/main.js:80131:9
onKeyDown@http://localhost:9876/main.js:79661:17
EventListener.handleEvent*bind@http://localhost:9876/main.js:78942:9
bindEvents@http://localhost:9876/main.js:78975:13
init@http://localhost:9876/main.js:78824:9
FlatpickrInstance@http://localhost:9876/main.js:80478:5
…

I guess there should be a check that the value is a correct date.

Thanks!

[chmln]

Hello,

flatpickr does check whether the input is a valid date.
Its not an exception, but a console warning.
You can handle errors yourself if you dont want them in the console.

Use the errorHandler option.

{
  errorHandler: (error) => { 
    // do something
  }

[Phyks]

Oh, ok, I missed the errorHandler setting. Thanks! (sorry for the noise :/)

[chmln]

No problem 👍. It should really be documented better

[bnjbvr]

Sorry, I think this issue isn't quite done yet: if you create a Flatpickr instance and pass it an errorHandler function, then the following happens:

• createDateParser is called from the main ctor; note there's no config key in the self object https://github.com/chmln/flatpickr/blob/master/src/index.ts#L51
• createDateParser looks if there's a config passed; if there's not, it uses the defaults set of handlers. In particular, since it returns a closure, the config that's set to defaults is captured in the closure https://github.com/chmln/flatpickr/blob/master/src/utils/dates.ts#L34

This means that even if we pass options, if the parser created with createDateParser survives, then the error handler will be plainly ignored, since it's going to use the default one.

Can you reopen the issue, please?

[chmln]

@bnjbvr fixed in #1196