Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged sensors change look when refreshed(autorefresh) #19

Open
xztraz opened this issue Feb 25, 2018 · 17 comments
Open

merged sensors change look when refreshed(autorefresh) #19

xztraz opened this issue Feb 25, 2018 · 17 comments

Comments

@xztraz
Copy link
Contributor

xztraz commented Feb 25, 2018

after say 30 seconds merged items expand to larger size

image

seem to be this refresh

THEME JS - clock: tick tock
custom.js:939 //ajax devices
custom.js:942 -------------
custom.js:943 THEME JS - ajax listener: devices update
custom.js:946 THEME JS - ajax: observer: fresh JSON for devices
custom.js:947 (3) [{…}, {…}, {…}]
custom.js:949 fresh json, starting in 20 milliseconds.
custom.js:1195 Dividers exist but have not been merged. Running improvements.
custom.js:1214 inside mergeDividers
custom.js:1261 THEME JS - improveClasses starting, currentPage = dashboard
custom.js:1371 THEME JS - showing last update in new footer
custom.js:1389 THEME JS - Adding battery icon.
custom.js:1425 THEME JS - inside newData.
2custom.js:1461 THEME JS - found a BR in status output, surgically removing
custom.js:1497 THEME JS - fixing found comma separated data
dashboard_merge_items_with_same_name.js:5 THEME JS - merging items
dashboard_merge_items_with_same_name.js:51 THEME JS - merging: bandlist existed.
dashboard_merge_items_with_same_name.js:102 merging: bandleader already prepared
custom.js:1585 THEME JS - newdata: updating battery level info for Ute-Temp
custom.js:1617 THEME JS - hiding Dew Point data
custom.js:1585 THEME JS - newdata: updating battery level info for Ute-Vind
custom.js:1617 THEME JS - hiding Dew Point data
custom.js:1585 THEME JS - newdata: updating battery level info for Energi
custom.js:1617 THEME JS - hiding Dew Point data
dashboard_merge_items_with_same_name.js:5 THEME JS - merging items
dashboard_merge_items_with_same_name.js:51 THEME JS - merging: bandlist existed.
dashboard_merge_items_with_same_name.js:102 merging: bandleader already prepared
dashboard_show_data_visualizations.js:18 THEME JS - dataviz is enabled
custom.js:1891 THEME JS - clock: tick tock

@flatsiedatsie
Copy link
Owner

I'm not able to reproduce this.

CSS on the icons (right click ->inspect) should be something like:

@media (min-width: 768px)
#dashcontent h2 + div.divider .span4:nth-child(-n+3) div.item.bandleader.withstatus.statuscount5 td#status > .wrapper img, #dashcontent h2 + div.divider .span4:nth-child(-n+3) div.item.bandleader.withstatus.statuscount5 td.status > .wrapper img, #dashcontent h2 + div.divider .span4:nth-child(-n+3) div.item.bandleader.withstatus.statuscount6 td#status > .wrapper img, #dashcontent h2 + div.divider .span4:nth-child(-n+3) div.item.bandleader.withstatus.statuscount6 td.status > .wrapper img {
height: 16px;
width: 16px;
/* top: 8px; */
display: inline-block!important;
}

What's your window size?
Are you on compact mode?

@xztraz
Copy link
Contributor Author

xztraz commented Feb 26, 2018

before muckup
image

after muckup (try scrolling a bit up and down. takes about 30 sec to show sometimes)
image

settings
image
image

@xztraz
Copy link
Contributor Author

xztraz commented Feb 26, 2018

Seem to loose some styling when data reloads sometimes

before
image

after
image

@xztraz
Copy link
Contributor Author

xztraz commented Feb 26, 2018

btw. the sensor don't update all values at the same time. there are 2 different packets from weatherstation that get updates on different sensors in the station. wind speed every time, alternating temp/hum and winddir. if that could be affecting

@flatsiedatsie
Copy link
Owner

Perhaps that's it. The theme tries its best to figure out when new data is available, and listens for interface changes. But this 'hooking into' Domoticz is not the optimal solution. A future version of Domoticz would ideally call a function in the theme.js file, to tell the theme to apply its desired modifications.

@flatsiedatsie
Copy link
Owner

Ah, form the picture I can see that it loses the "withstatus" class.

@xztraz
Copy link
Contributor Author

xztraz commented Mar 1, 2018

well spotted. but what does it mean? other than then styling is lost :D

@flatsiedatsie
Copy link
Owner

I've uploaded a change to the css to make it less fussy about having that class. It might solve your problem. Or introduce new ones :-)

@xztraz
Copy link
Contributor Author

xztraz commented Mar 1, 2018

Almost there. icon size stays small now but there is something making a newline

Before:
image

After sensor update:
image

@xztraz
Copy link
Contributor Author

xztraz commented Mar 3, 2018

And seem to loose some indent or margin too. I also get the same on some standard temp sensors (with humidity)

@xztraz
Copy link
Contributor Author

xztraz commented Mar 7, 2018

image
the grouping feature seem to group items a bit randomly. different groups of termometers, shows duplicates.

@flatsiedatsie
Copy link
Owner

Is this still an issue? I remember trying to fix this.

The grouping this is a new issue. I have no idea how that's possible.

@xztraz
Copy link
Contributor Author

xztraz commented Apr 30, 2018

haven't tried since your last update but then it was an issue with the random grouping atleast. have to try again

@xztraz
Copy link
Contributor Author

xztraz commented May 3, 2018

Icon scale seem ok now. but i get rowbreaks?(after a while, looks ok at first) and the grouping is weird.

@xztraz xztraz changed the title merged sensors change scale when refreshed(autorefresh) merged sensors change look when refreshed(autorefresh) May 3, 2018
@xztraz
Copy link
Contributor Author

xztraz commented May 3, 2018

one more weird behavior is that if i rearange the merged blocks they dissapear. so order seem to matter too

@bloedersack
Copy link

I have a similar problem with grouping

In the first group the symbol of the air pressure is missing and the symbols are right justified. The second one's okay. For the last group, the symbol is too large and a symbol is missing.

image

OS, Domoticz (Beta) and Aurora are up-to-date. Browser cache etc. deleted.

@flatsiedatsie
Copy link
Owner

Thanks. This part should probably be remade some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants