Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e-antic build failure with flint 2.7.0 #154

Closed
videlec opened this issue Dec 18, 2020 · 7 comments
Closed

e-antic build failure with flint 2.7.0 #154

videlec opened this issue Dec 18, 2020 · 7 comments

Comments

@videlec
Copy link
Collaborator

videlec commented Dec 18, 2020 •
edited
Loading

flint changed the API of fmpz_mod_poly. Build fails for e-antic 0.1 (see https://trac.sagemath.org/ticket/31069) and probably for 1.0 as well.
@antonio-rojas antonio-rojas mentioned this issue Dec 19, 2020
Merged
2 tasks
@thierry-FreeBSD
Copy link

For release 0.1.8, the error messages are:

libtool: compile:  cc -DHAVE_CONFIG_H -I. -isystem /usr/local/include -fopenmp -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -MT nf_elem/get_fmpz_mod_poly.lo -MD -MP -MF nf_elem/.deps/get_fmpz_mod_poly.Tpo -c nf_elem/get_fmpz_mod_poly.c  -fPIC -DPIC -o nf_elem/.libs/get_fmpz_mod_poly.o
nf_elem/get_fmpz_mod_poly.c:32:31: error: too few arguments to function call, expected 2, have 1
        fmpz_mod_poly_zero(pol);
        ~~~~~~~~~~~~~~~~~~    ^
/usr/local/include/flint/fmpz_mod_poly.h:268:1: note: 'fmpz_mod_poly_zero' declared here
FMPZ_MOD_POLY_INLINE 
^
/usr/local/include/flint/fmpz_mod_poly.h:19:30: note: expanded from macro 'FMPZ_MOD_POLY_INLINE'
#define FMPZ_MOD_POLY_INLINE static __inline__
                             ^
nf_elem/get_fmpz_mod_poly.c:38:44: error: too few arguments to function call, expected 3, have 2
            fmpz_mod_poly_fit_length(pol, 1);
            ~~~~~~~~~~~~~~~~~~~~~~~~       ^
/usr/local/include/flint/fmpz_mod_poly.h:124:11: note: 'fmpz_mod_poly_fit_length' declared here
FLINT_DLL void fmpz_mod_poly_fit_length(fmpz_mod_poly_t poly, slong len,
          ^
nf_elem/get_fmpz_mod_poly.c:39:66: error: no member named 'p' in 'fmpz_mod_poly_struct'
            fmpz_mod(pol->coeffs + 0, LNF_ELEM_NUMREF(a), &(pol->p));
                                                            ~~~  ^
nf_elem/get_fmpz_mod_poly.c:46:40: error: too few arguments to function call, expected 3, have 2
        fmpz_mod_poly_fit_length(pol, 3);
        ~~~~~~~~~~~~~~~~~~~~~~~~       ^
/usr/local/include/flint/fmpz_mod_poly.h:124:11: note: 'fmpz_mod_poly_fit_length' declared here
FLINT_DLL void fmpz_mod_poly_fit_length(fmpz_mod_poly_t poly, slong len,
          ^
nf_elem/get_fmpz_mod_poly.c:47:62: error: no member named 'p' in 'fmpz_mod_poly_struct'
        fmpz_mod(pol->coeffs + 0, QNF_ELEM_NUMREF(a), &(pol->p));
                                                        ~~~  ^
nf_elem/get_fmpz_mod_poly.c:48:66: error: no member named 'p' in 'fmpz_mod_poly_struct'
        fmpz_mod(pol->coeffs + 1, QNF_ELEM_NUMREF(a) + 1, &(pol->p));
                                                            ~~~  ^
nf_elem/get_fmpz_mod_poly.c:49:66: error: no member named 'p' in 'fmpz_mod_poly_struct'
        fmpz_mod(pol->coeffs + 2, QNF_ELEM_NUMREF(a) + 2, &(pol->p));
                                                            ~~~  ^
nf_elem/get_fmpz_mod_poly.c:56:42: error: too few arguments to function call, expected 3, have 2
        fmpz_mod_poly_fit_length(pol, len);
        ~~~~~~~~~~~~~~~~~~~~~~~~         ^
/usr/local/include/flint/fmpz_mod_poly.h:124:11: note: 'fmpz_mod_poly_fit_length' declared here
FLINT_DLL void fmpz_mod_poly_fit_length(fmpz_mod_poly_t poly, slong len,
          ^
nf_elem/get_fmpz_mod_poly.c:58:69: error: no member named 'p' in 'fmpz_mod_poly_struct'
            fmpz_mod(pol->coeffs + i, NF_ELEM_NUMREF(a) + i, &(pol->p));
                                                               ~~~  ^
nf_elem/get_fmpz_mod_poly.c:70:71: error: too few arguments to function call, expected 4, have 3
            fmpz_mod_poly_scalar_div_fmpz(pol, pol, LNF_ELEM_DENREF(a));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                             ^
/usr/local/include/flint/fmpz_mod_poly.h:441:11: note: 'fmpz_mod_poly_scalar_div_fmpz' declared here
FLINT_DLL void fmpz_mod_poly_scalar_div_fmpz(fmpz_mod_poly_t res, 
          ^
nf_elem/get_fmpz_mod_poly.c:72:71: error: too few arguments to function call, expected 4, have 3
            fmpz_mod_poly_scalar_div_fmpz(pol, pol, QNF_ELEM_DENREF(a));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                             ^
/usr/local/include/flint/fmpz_mod_poly.h:441:11: note: 'fmpz_mod_poly_scalar_div_fmpz' declared here
FLINT_DLL void fmpz_mod_poly_scalar_div_fmpz(fmpz_mod_poly_t res, 
          ^
nf_elem/get_fmpz_mod_poly.c:74:70: error: too few arguments to function call, expected 4, have 3
            fmpz_mod_poly_scalar_div_fmpz(pol, pol, NF_ELEM_DENREF(a));
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                            ^
/usr/local/include/flint/fmpz_mod_poly.h:441:11: note: 'fmpz_mod_poly_scalar_div_fmpz' declared here
FLINT_DLL void fmpz_mod_poly_scalar_div_fmpz(fmpz_mod_poly_t res, 
          ^
12 errors generated.
gmake[2]: *** [Makefile:2694: nf_elem/get_fmpz_mod_poly.lo] Error 1

@thierry-FreeBSD
Copy link

For 1.0.0-rc.9, the error messages are:

libtool: compile:  cc -DHAVE_CONFIG_H -I. -I. -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -MT fmpz_poly_extra/randtest_irreducible.lo -MD -MP -MF fmpz_poly_extra/.deps/randtest_irreducible.Tpo -c fmpz_poly_extra/randtest_irreducible.c  -fPIC -DPIC -o fmpz_poly_extra/.libs/randtest_irreducible.o
fmpz_poly_extra/randtest_irreducible.c:25:27: warning: incompatible pointer types passing 'fmpz_t' (aka 'fmpz [1]') to parameter of type 'const fmpz_mod_ctx_struct *' (aka 'const struct fmpz_mod_ctx *') [-Wincompatible-pointer-types]
    fmpz_mod_poly_init(q, c);
                          ^
/usr/local/include/flint/fmpz_mod_poly.h:108:68: note: passing argument to parameter 'ctx' here
void fmpz_mod_poly_init(fmpz_mod_poly_t poly, const fmpz_mod_ctx_t ctx)
                                                                   ^
fmpz_poly_extra/randtest_irreducible.c:26:53: error: too few arguments to function call, expected 4, have 3
    fmpz_mod_poly_randtest_irreducible(q, state, len);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~              ^
/usr/local/include/flint/fmpz_mod_poly.h:174:11: note: 'fmpz_mod_poly_randtest_irreducible' declared here
FLINT_DLL void fmpz_mod_poly_randtest_irreducible(fmpz_mod_poly_t f,
          ^
fmpz_poly_extra/randtest_irreducible.c:28:37: error: too few arguments to function call, expected 3, have 2
    fmpz_mod_poly_get_fmpz_poly(p, q);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~     ^
/usr/local/include/flint/fmpz_mod_poly.h:312:11: note: 'fmpz_mod_poly_get_fmpz_poly' declared here
FLINT_DLL void fmpz_mod_poly_get_fmpz_poly(fmpz_poly_t f,
          ^
fmpz_poly_extra/randtest_irreducible.c:41:26: error: too few arguments to function call, expected 2, have 1
    fmpz_mod_poly_clear(q);
    ~~~~~~~~~~~~~~~~~~~  ^
/usr/local/include/flint/fmpz_mod_poly.h:118:11: note: 'fmpz_mod_poly_clear' declared here
FLINT_DLL void fmpz_mod_poly_clear(fmpz_mod_poly_t poly,
          ^
1 warning and 3 errors generated.
gmake[2]: *** [Makefile:2195: fmpz_poly_extra/randtest_irreducible.lo] Error 1

@saraedum
Copy link
Member

Fixed in #155 .

@saraedum
Copy link
Member

I don't think we will fix the 0.1 series. Or did you plan to do so @videlec ?

@videlec
Copy link
Collaborator Author

videlec commented Jan 23, 2021

Nope.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 23, 2021

Really, a "wontfix"?

@videlec
Copy link
Collaborator Author

videlec commented Feb 23, 2021

You are welcome to provide a pull request.

@slel slel mentioned this issue May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@saraedum @videlec @thierry-FreeBSD @mkoeppe