-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples with deprecated fits module of flavio #3
Comments
True, the examples are all outdated. |
Can you point out what changes should be make to get these examples working in flavio v2.0.0, as the signature has changed for both FastLikelihood constructor and method log_likelihood. |
In the example FastFit_WilsonCoefficients_C7p.ipynb i changed
and changed the likelihood functions like
@DavidMStraub can you please tell if these changes are sufficient? This might not be the best place to ask but I also wanted to know how to add multiple instances of an observable with same bins from different experiments for likelihood as I didn't see any examples with this case. |
Hi, yes, looks good. The instantiation for from wilson import Wilson
...
def ll(x):
wc_NP = Wilson({"C7p_bs": ...}, scale=4.8, eft="WET", basis="flavio")
... |
@DavidMStraub can you please tell how to handle the case of adding multiple instances for some observable with same bins. I see the case with multiple measurements for an observable in you code for paper bkstartmumu, but how to handle the case when even the bins are same for an observable. |
For every bin, all existing measurements will be taken into account automatically. Thus one has to be careful not to double-count. You should also consider using smelli which was developed precisely with the goal to abstract away these subtleties. |
I was trying to understand what how flavio takes multiple measurements into account. For the example given in notebook FastFit_WilsonCoefficients_C7p the number of observables given by Does it combine the distributions while calculating χ2 in FastLikelihood? |
As per the doc string, the number of observations is "defined as individual measurements of observables". Apparently, here there is one of the 8 observables that is measured by two experiments. |
So it combines the the distributions where it finds more than one measurement for an observable? |
Sure. But it's in the user's responsability to be careful that these measurements are actually independent. For instance, for |
Can you please share the updated
Can you please share the updated .ipython for these 3 examples? I am new to this package and facing lots of error while trying to modify the outdated examples? |
Usage of deprecated module (as mentioned in documentation):
import flavio.statistics.fits
Recent installations will have following error:
Following ipython examples use the
fits
module:FastFit_WilsonCoefficients_C7p.ipynb
FastFit_WilsonCoefficients_CS_CSp.ipynb
FrequentistFit_VubVcb_Profiler.ipynb
They should be replaced with the relevant
flavio.statistics.likelihood
methods.The text was updated successfully, but these errors were encountered: