Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs should run in a clean environment #127

Open
mikfreedman opened this issue Mar 3, 2019 · 1 comment
Open

Specs should run in a clean environment #127

mikfreedman opened this issue Mar 3, 2019 · 1 comment
Labels
type/bug
Projects
Backlog

Comments

@mikfreedman
Copy link
Collaborator

Unless explicitly specified with the with_temp_calendar_assistant_home helper, specs can (and sometimes do) access the user's local configuration in ~/.calendar-assistant*.

This is probably not ideal because:

  • Tests (especially unit tests) probably shouldn't access local configuration
  • A broken configuration will cause tests to fail unnecessarily
  • A weird configuration might create inconsistent test results.
@mikfreedman
Copy link
Collaborator Author

This is hard to solve immediately due to the way Thor's configuration is specified. We currently read local configuration when specifying our Commands class.

@mikfreedman mikfreedman mentioned this issue Mar 3, 2019
Merged
@mikfreedman mikfreedman added this to Icebox / Needs breakdown in Backlog via automation Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
Backlog
  
Icebox / Needs breakdown
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikfreedman