[Bug] Metallic materials aren't affected by Skylight

[Myterian]

Issue description:
Skylight don't affect metallic materials, making them unnaturally dark in shadowed areas. Watch the cannon in the front.

No Skylight

A bit Skylight

A lot Skylight

Steps to reproduce:

1. Add an object to your scene
2. Create a material, set Metalness to 1
3. Create Skylight in scene
4. Play with Skylight brightness and observe

Minimal reproduction project:
Basic

Flax version:
1.8.6512.2

[mafiesto4]

Is there an environment probe in that scene? Metallic materials use reflection probes to get lighting (diffuse is mostly black).

[Myterian]

So, reflections probes solved the problem, you can see the shadowed parts now. There is a new issue, tho, as that the reflection probe makes everything shiny or 'wet', even on completly rough surfaces and especially in shadowed areas. Like the cannons appear shiny, but have the same roughness values as the wood crate next to them.

Do you think this could be fixed with by making metalic materials use things like skylight instead of reflections or is this as good as it gets?

[mafiesto4]

Maybe we could add an optional intensity slider to skylight for mixing with reflections (can scale the alpha channel of the output light buffer which is used for reflections intensity mixing). Or shadowed skylight would improve the quality in shadowed areas: #1189

[Myterian]

Sounds good

[Myterian]

I just found another good reason for skylights in metallic materials:

In dynamic day and night scenes, metallic parts are unaffected by the light changes. Which makes them stick out