Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the background & contrast handles to make crop handles more visible. #4

Open
fadulalla opened this issue Oct 24, 2020 · 2 comments

Comments

@fadulalla
Copy link

Hey, great package!

One request though: as handles stand, they can be difficult (and sometimes impossible) to see when cropping light images or images with white backgrounds (such as memes and and grid comics).

I'd like to suggest inverting the background so that the crop area itself is clear, and the area around it is dimmed. Also, adding a stroke to the border of the crop area should make it more visible, to contrast a possible light background. See before and after below.

Before:
image

I've made the changes in a fork, here:
image

If you agree with these suggestions, I'm happy to make any changes to my fork and open a PR. If not then I'm also happy to publish my fork as an alternative to your package.

Other than that, I just want to say great package, really. I've tried 2-3 cropping packages and none of them had everything I needed. This one did, super simple!

@pulstar
Copy link

pulstar commented Nov 11, 2020

Much better!

@diegoflassa
Copy link

Create a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants